Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Conversation

@lzpap
Copy link
Collaborator

@lzpap lzpap commented Jan 23, 2020

Related: #268 and #284

Description

  • Add 6. Store Encrypted Data tutorial to show how one can put encrypted data on the Tangle.
  • Add 7. Fetch Encrypted Data tutorial to show how one can fetch and read encrypted data from the Tangle
  • The two tutorials need to be studied one after the other.

lzpap added 3 commits January 22, 2020 11:44
- show simpple way of encrypting data before
  sending it to the Tangle
- show how to decrypt data from Tutorial 6
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ minor suggestions/questions.

Comment on lines 44 to 46
my_address = AddressGenerator(b'YOURSEEDFROMTHEPREVIOUSTUTORIAL').get_addresses(
start=42,
)[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ Could we provide the seed to Iota.__init__() on line 15, and then use api.get_new_addresses() here instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely! It's less confusing as well, there is no need for user to know about the existence of AddressGenerator. :)

Copy link
Collaborator Author

@lzpap lzpap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @todofixthis for the review and finding my typos! 😃

Comment on lines 44 to 46
my_address = AddressGenerator(b'YOURSEEDFROMTHEPREVIOUSTUTORIAL').get_addresses(
start=42,
)[0]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely! It's less confusing as well, there is no need for user to know about the existence of AddressGenerator. :)

@lzpap lzpap merged commit bf4915b into iotaledger-archive:develop Jan 24, 2020
@lzpap lzpap deleted the tutorial6 branch January 28, 2020 10:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants