Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Conversation

@lzpap
Copy link
Collaborator

@lzpap lzpap commented Feb 27, 2020

Solves: #302

Description

Source code changes:

  • Raise a BadApiResponse exceptions when getTrytes returns empty trytes.

Test code changes:

  • Add tests for get_bundles_from_transactions_hashes:
    • Single tx bundle successfully fetched given tail with inclusion states,
    • Single tx bundle successfully fetched given tail without inclusion states,
    • Called with empty list,
    • Exception is raised when node returns empty trytes,
    • Called with tail transactions, multiple bundles are fetched,
    • Called with a non-tail transaction, tail and bundle correctly fetched,
    • Returned bundles are sorted in ascending order based on timestamp.

Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzpap lzpap merged commit 202c811 into iotaledger-archive:develop Feb 28, 2020
@lzpap lzpap mentioned this pull request Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants