Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Conversation

@lzpap
Copy link
Collaborator

@lzpap lzpap commented May 29, 2020

Description of change

Fixes #320

Add a new extended api call is_confirmed to determine if a set of transactions have been confirmed by the network. It is an alias for get_inclusion_states.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Just an alias, tests remain the same.

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (docs/ directory and/or docstrings in source code)
  • I have followed PEP-8 Style Guide in my code.
  • New and existing unit tests pass locally with my changes

Which is essentially an alias for `get_inclusion_states`, but
with a more descriptive name for devs.
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzpap lzpap merged commit 04e2053 into iotaledger-archive:develop Jun 4, 2020
@lzpap lzpap deleted the is_confirmed_alias branch June 4, 2020 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants