This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Attempt at Issue #31. #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todofixthis
suggested changes
Jul 31, 2017
Contributor
There was a problem hiding this comment.
Hey John. Thanks for submitting this pull request!
The purpose of this script is to serve as documentation for developers. I think we should focus less on creating a functional application here, and put more work into producing a reference implementation.
Some ideas for how to go about this:
- Use an approach similar to the one you did for the routingwrapper example script:
- Strip the code down to the bare essentials, and use hard-coded/dummy values where needed.
- Add lots of comments explaining what each component does and why it is needed.
- In this case, it's probably better that the application doesn't run, since in a worst-case scenario it could cause a user to accidentally spend IOTAs!
todofixthis
approved these changes
Aug 1, 2017
Contributor
|
Thanks! Merging.. |
marko-k0
pushed a commit
to marko-k0/iota.lib.py
that referenced
this pull request
Jul 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at an example script that shows how to use PyOTA to send a transfer to another address.