Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Conversation

@HerrMuellerluedenscheid
Copy link
Contributor

@HerrMuellerluedenscheid HerrMuellerluedenscheid commented Oct 20, 2017

fixes #83

debian jessie's (and maybe others?) apt-get ships a rather deprecated version of setuptools (5.5.1). Setup of pyota failed with a rather unclear exiting message:

X@Y:/usr/local/src/pyota$ sudo python setup.py install 
error in PyOTA setup command: 'install_requires' must be a string or list of strings containing valid 
project/version requirement specifiers

Same with installing via pip. I went through the version log of setuptools and found 'install_requires' was touched in versions 5.5, 20.5. and later. I tested with version 20.7. with which setup was flawless. So, I assume version 20.5. is the minimum requirement.

setup does require setuptools version >= 20.5
@todofixthis
Copy link
Contributor

Hey @HerrMuellerluedenscheid thanks for your pull request! This is a great idea!

Couple of requests:

  • Could you change your PR so that it uses develop as the target branch?
  • Could you modify the error message so that it indicates the minimum setuptools version number?

@HerrMuellerluedenscheid HerrMuellerluedenscheid changed the base branch from master to develop October 23, 2017 20:29
@todofixthis
Copy link
Contributor

Thanks @HerrMuellerluedenscheid ! Will do a final review later today.

@todofixthis
Copy link
Contributor

Looks good! Thanks!!

@todofixthis todofixthis merged commit 0868b15 into iotaledger-archive:develop Oct 24, 2017
@HerrMuellerluedenscheid HerrMuellerluedenscheid deleted the fix_setup branch December 14, 2017 09:09
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this pull request Jul 28, 2018
…/fix_setup

setup: Check for setuptools version and inform user
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants