Skip to content

Conversation

@obany
Copy link
Contributor

@obany obany commented Mar 10, 2021

Description of change

Show the network indicator as down when no status endpoints can be reached

Fixes

fixes #346 (comment)

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Tested with network disconnected

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@obany obany requested a review from cvarley100 as a code owner March 10, 2021 10:48
@begonaalvarezd begonaalvarezd merged commit abff3b8 into develop Mar 10, 2021
@begonaalvarezd begonaalvarezd deleted the fix/network-indicator-down branch March 10, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some minor interface issues list

3 participants