Skip to content

Conversation

@obany
Copy link
Contributor

@obany obany commented Mar 10, 2021

Description of change

Adds the ability to manual sync accounts with refresh on transactions panel.
The sync at login is also now done as a background task, which reduces the time it shows the busy screen for when logging in. This was very slow on large accounts (or stopped if no internet connection), making it look like the app had crashed, instead the manual sync indicator is active on login.
The settings->resync is also wired in to the same processing (possible we could remove this now that you can sync from the main UI)

Fixes

#351 #331

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Test on windows, mac and ubuntu

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@obany obany requested a review from cvarley100 as a code owner March 10, 2021 12:37
@cvarley100 cvarley100 merged commit aff49d8 into develop Mar 11, 2021
@cvarley100 cvarley100 deleted the fix/manual-sync-accounts branch March 11, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants