fix: Cleanup the signup detail on login #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvarley100
reviewed
Mar 17, 2021
packages/shared/lib/app.ts
Outdated
| * Log in to the current profile | ||
| */ | ||
| export const login = () => { | ||
| cleanupSignup() |
Contributor
There was a problem hiding this comment.
Do we need to clear these on every login?
Contributor
Author
There was a problem hiding this comment.
I have moved it to be called alongside the login for the signup flow.
cvarley100
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Tidies up the signup details on completing the process.
Also only show the account loading busy popup if logged in
Links to any relevant issues
Fixes #359 and #456
Type of change
How the change has been tested
Tested on windows
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.