feat: group confirmations state notifications for internal transfers #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfernog
reviewed
Mar 21, 2021
| ); | ||
|
|
||
| confirmedInternalMessageIds.update((ids) => { | ||
| delete ids[message.id] |
Contributor
There was a problem hiding this comment.
do we need to create a new object here? since the update shouldn't mutate the object AFAIK
Author
There was a problem hiding this comment.
No it is fine. It updates all refs and also preserves reactivity.
Contributor
There was a problem hiding this comment.
I also think we could get away with this with a simple JS object instead of a svelte store, but this looks good.
lucasfernog
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR group notifications for internal transfers i.e., no duplicate notifications when a transaction gets confirmed.
Links to any relevant issues
N/A
Type of change
How the change has been tested
Manually tested macOS
Change checklist