Skip to content

fix: minor fixes #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2021
Merged

fix: minor fixes #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2fab16
fix: set unit for 0 to Mi
cvarley100 Mar 22, 2021
ef20d67
fix: capitalisation of strings
cvarley100 Mar 22, 2021
62bee6b
fix: change inputAddress string
cvarley100 Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/shared/lib/units.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ export const formatUnit = (value: number, decimalPlaces = 2): string => {
const getUnit = (value: number): Unit => {
let bestUnits: Unit = Unit.i

if (!value) {
return bestUnits
if (!value || value === 0) {
return Unit.Mi
}

const checkLength = Math.abs(value).toString().length
Expand Down
12 changes: 6 additions & 6 deletions packages/shared/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,8 +472,8 @@
"recentActivity": "Recent Activity",
"sent": "Sent",
"received": "Received",
"sendPayment": "Send payment",
"moveFunds": "Move funds",
"sendPayment": "Send Payment",
"moveFunds": "Internal Transfer",
"sendFunds": "Send funds",
"sendToAddress": "Send to address",
"scanQrOrPaste": "Scan a QR code or paste an Address",
Expand All @@ -488,7 +488,7 @@
"reference": "Reference",
"from": "From",
"to": "To",
"receiveFunds": "Receive funds",
"receiveFunds": "Receive Funds",
"myAddress": "My Address",
"shareAddress": "Share an address",
"yourAddress": "Your address",
Expand All @@ -512,13 +512,13 @@
"totalIn": "Total in",
"totalOut": "Total out",
"accounts": "Accounts",
"myAccounts": "My accounts",
"myAccounts": "My Accounts",
"automaticNodeSelection": "Automatic node selection",
"manualNodeSelection": "Manual node selection",
"profiles": "Profiles",
"developerProfile": "Developer Profile",
"dev": "Dev",
"createAccount": "Create an account",
"createAccount": "Create an Account",
"accountName": "Account name",
"latestTransactions": "Latest Transactions",
"transactions": "Transactions",
Expand All @@ -529,7 +529,7 @@
"help": "Help",
"you": "You",
"messageId": "Message ID",
"inputAddress": "Input Address",
"inputAddress": "Send Address",
"receiveAddress": "Receive Address",
"date": "Date",
"status": "Status",
Expand Down