Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
e73bd56
feat: Sync SDK types
marc2332 Mar 22, 2024
4d28457
feat: stop generating txs out of outputs
marc2332 Mar 22, 2024
71f88e7
fix: tx history: include account output in average txs
Mar 22, 2024
eb19a90
Merge branch 'develop-iota2.0' into feat/sync-sdk-types
cpl121 Mar 22, 2024
a850bb8
Merge branch 'feat/sync-sdk-types' into feat/stop-generating-txs-out-…
cpl121 Mar 22, 2024
3cedefe
Merge branch 'feat/stop-generating-txs-out-of-outputs' into fix/tx-hi…
cpl121 Mar 22, 2024
e499fa4
fix: Fix incorrect timestamp in Incoming txs
marc2332 Mar 25, 2024
4098672
fix: Receive funds to implicit account address
marc2332 Mar 25, 2024
07cf0a4
Merge branches 'fix/tx-history-include-account-output-in-avg-txs' and…
Mar 25, 2024
c3f486e
Merge branch 'develop-iota2.0' into fix/tx-history-include-account-ou…
cpl121 Mar 25, 2024
a501aa2
Merge branch 'fix/tx-history-include-account-output-in-avg-txs' into …
cpl121 Mar 25, 2024
ea52b1c
Merge branch 'fix/incorrect-timestamp-incoming-txs' into fix/receive-…
cpl121 Mar 25, 2024
de89392
Merge branch 'develop-iota2.0' into fix/tx-history-include-account-ou…
cpl121 Mar 25, 2024
278543c
Merge branch 'fix/tx-history-include-account-output-in-avg-txs' into …
cpl121 Mar 25, 2024
f3f4e32
Merge branch 'fix/incorrect-timestamp-incoming-txs' into fix/receive-…
cpl121 Mar 25, 2024
e07821c
Merge branches 'fix/incorrect-timestamp-incoming-txs' and 'develop-io…
Mar 25, 2024
c1d22a9
Merge branch 'fix/incorrect-timestamp-incoming-txs' into fix/receive-…
cpl121 Mar 25, 2024
a4f5c78
feat: add mana to txs in tx activities and activity details
Mar 26, 2024
a0f9cb2
fix: Use sdk types for inclusion state
marc2332 Mar 26, 2024
a9e69c1
fix
marc2332 Mar 26, 2024
d96e4ed
fix
marc2332 Mar 26, 2024
73ef4e6
feat: rename reject to ignore outputs in the tx history
Mar 27, 2024
541013a
Merge branch 'develop-iota2.0' into fix/incorrect-timestamp-incoming-txs
cpl121 Mar 27, 2024
8d3126b
Merge branch 'fix/incorrect-timestamp-incoming-txs' into fix/receive-…
cpl121 Mar 27, 2024
ba82151
Merge branch 'fix/receive-funds-to-implicit-account-address' into fea…
cpl121 Mar 27, 2024
d0cf2b7
Merge branch 'feat/add-mana-to-tx-history' into fix/use-sdk-types-inc…
cpl121 Mar 27, 2024
dbb2bd5
Merge branch 'fix/use-sdk-types-inclusion-state-tx-status' into feat/…
cpl121 Mar 27, 2024
f68a9e5
Merge branch 'develop-iota2.0' into feat/rename-reject-to-ignore
marc2332 Mar 28, 2024
ac8bcaa
Merge branch 'develop-iota2.0' into feat/rename-reject-to-ignore
begonaalvarezd Mar 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/specifications/activities/class-diagram.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ classDiagram
- asyncStatus: ActivityAsyncStatus
- timelockDate: Date
- expirationDate: Date
- isRejected: boolean
- isIgnored: boolean
- isClaiming: boolean
- claimingTransactionId: string
- claimedDate: Date
Expand Down
20 changes: 10 additions & 10 deletions packages/desktop/components/popups/ActivityDetailsPopup.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
ActivityDirection,
ActivityType,
claimActivity,
rejectActivity,
ignoreActivity,
selectedWallet,
selectedWalletActivities,
} from '@core/wallet'
Expand Down Expand Up @@ -82,17 +82,17 @@
}
}

function onRejectClick(): void {
function onIgnoreClick(): void {
openPopup({
id: PopupId.Confirmation,
props: {
title: localize('actions.confirmRejection.title'),
description: localize('actions.confirmRejection.description'),
hint: localize('actions.confirmRejection.node'),
confirmText: localize('actions.reject'),
title: localize('actions.confirmIgnore.title'),
description: localize('actions.confirmIgnore.description'),
hint: localize('actions.confirmIgnore.node'),
confirmText: localize('actions.ignore'),
variant: TextHintVariant.Warning,
onConfirm: () => {
rejectActivity(activityId)
ignoreActivity(activityId)
closePopup()
},
onCancel: () =>
Expand Down Expand Up @@ -161,10 +161,10 @@
<Button
outline
classes="w-full"
disabled={activity.asyncData?.isClaiming || activity.asyncData?.isRejected}
onClick={onRejectClick}
disabled={activity.asyncData?.isClaiming || activity.asyncData?.isIgnored}
onClick={onIgnoreClick}
>
{localize('actions.reject')}
{localize('actions.ignore')}
</Button>
<Button
classes="w-full"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
ActivityAsyncStatus,
ActivityDirection,
claimActivity,
rejectActivity,
ignoreActivity,
getTimeDifference,
Activity,
} from '@core/wallet'
Expand All @@ -26,17 +26,17 @@
$: timeDiff = getTimeDiff(activity)
$: hasExpirationTime = !!activity.asyncData?.expirationDate

function onRejectClick(): void {
function onIgnoreClick(): void {
openPopup({
id: PopupId.Confirmation,
props: {
title: localize('actions.confirmRejection.title'),
description: localize('actions.confirmRejection.description'),
hint: localize('actions.confirmRejection.node'),
title: localize('actions.confirmIgnore.title'),
description: localize('actions.confirmIgnore.description'),
hint: localize('actions.confirmIgnore.node'),
variant: TextHintVariant.Warning,
confirmText: localize('actions.reject'),
confirmText: localize('actions.ignore'),
onConfirm: () => {
rejectActivity(activity.id)
ignoreActivity(activity.id)
closePopup()
},
},
Expand Down Expand Up @@ -84,13 +84,13 @@
<svelte:fragment slot="right">
{#if shouldShowActions}
<Button
onClick={onRejectClick}
disabled={activity.asyncData?.isClaiming || activity.asyncData?.isRejected}
onClick={onIgnoreClick}
disabled={activity.asyncData?.isClaiming || activity.asyncData?.isIgnored}
inlineStyle="min-width: 4rem;"
size={ButtonSize.Small}
outline
>
{localize('actions.reject')}
{localize('actions.ignore')}
</Button>
<Button
onClick={onClaimClick}
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/lib/core/wallet/actions/claimActivity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export async function claimActivity(activity: Activity): Promise<void> {
try {
if (isActivityHiddenForWalletId(wallet.id, activity.id)) {
removeActivityFromHiddenActivities(wallet.id, activity.id)
updateAsyncDataByActivityId(wallet.id, activity.id, { isRejected: false })
updateAsyncDataByActivityId(wallet.id, activity.id, { isIgnored: false })
}

updateAsyncDataByActivityId(wallet.id, activity.id, { isClaiming: true })
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { localize } from '@core/i18n'
import { showAppNotification } from '@auxiliary/notification'
import { activeProfileId } from '@core/profile'

export function rejectActivity(id: string): void {
export function ignoreActivity(id: string): void {
const walletId = get(selectedWalletId)
hiddenActivities.update((state) => {
const profileId = get(activeProfileId)
Expand All @@ -23,7 +23,7 @@ export function rejectActivity(id: string): void {
return state
})

updateAsyncDataByActivityId(walletId, id, { isRejected: true })
updateAsyncDataByActivityId(walletId, id, { isIgnored: true })
showAppNotification({
type: 'success',
alert: true,
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/lib/core/wallet/actions/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export * from './burnNft'
export * from './claimActivity'
export * from './getWalletAssetsForSelectedWallet'
export * from './generateAndStoreActivitiesForAllWallets'
export * from './rejectActivity'
export * from './ignoreActivity'
export * from './refreshWalletAssetsForActiveProfile'
export * from './requestPersistedAsset'
export * from './sendOutput'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ export const DEFAULT_ACTIVITY_FILTER: ActivityFilter = {
value: undefined,
},
},
showRejected: {
showIgnored: {
active: false,
type: 'selection',
localeKey: 'filters.showRejected',
localeKey: 'filters.showIgnored',
selected: BooleanFilterOption.Yes,
choices: [BooleanFilterOption.Yes, BooleanFilterOption.No],
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export interface ActivityFilter {
internalExternal: SelectionFilterUnit
asset: AssetFilterUnit
date: DateFilterUnit
showRejected: SelectionFilterUnit
showIgnored: SelectionFilterUnit
showHidden: SelectionFilterUnit
showValueless: SelectionFilterUnit
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export type AsyncData = {
asyncStatus: ActivityAsyncStatus
timelockDate: Date
expirationDate: Date
isRejected: boolean
isIgnored: boolean
isClaiming: boolean
claimingTransactionId: string
claimedDate: Date
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export async function getAsyncDataFromOutput(
const isClaiming = false
const claimingTransactionId = claimingData?.claimingTransactionId
const claimedDate = claimingData?.claimedDate
const isRejected = isActivityHiddenForWalletId(wallet.id, outputId)
const isIgnored = isActivityHiddenForWalletId(wallet.id, outputId)

const expirationDate = getExpirationDateFromOutput(commonOutput)
const timelockDate = getTimelockDateFromOutput(commonOutput)
Expand All @@ -36,7 +36,7 @@ export async function getAsyncDataFromOutput(
asyncStatus,
timelockDate,
expirationDate,
isRejected,
isIgnored,
isClaiming,
claimingTransactionId,
claimedDate,
Expand Down
8 changes: 4 additions & 4 deletions packages/shared/lib/core/wallet/utils/isVisibleActivity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function isVisibleActivity(activity: Activity): boolean {
if (!isVisibleWithActiveHiddenFilter(activity, filter)) {
return false
}
if (!isVisibleWithActiveRejectedFilter(activity, filter)) {
if (!isVisibleWithActiveIgnoredFilter(activity, filter)) {
return false
}
if (!isVisibleWithActiveAssetFilter(activity, filter)) {
Expand Down Expand Up @@ -75,10 +75,10 @@ function isVisibleWithActiveValuelessFilter(activity: Activity, filter: Activity
return true
}

function isVisibleWithActiveRejectedFilter(activity: Activity, filter: ActivityFilter): boolean {
function isVisibleWithActiveIgnoredFilter(activity: Activity, filter: ActivityFilter): boolean {
if (
(!filter.showRejected.active || filter.showRejected.selected === BooleanFilterOption.No) &&
activity.asyncData?.isRejected
(!filter.showIgnored.active || filter.showIgnored.selected === BooleanFilterOption.No) &&
activity.asyncData?.isIgnored
) {
return false
}
Expand Down
14 changes: 7 additions & 7 deletions packages/shared/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -1292,11 +1292,11 @@
"claim": "Claim",
"claiming": "Claiming",
"claimingRewards": "Claiming rewards",
"reject": "Reject",
"confirmRejection": {
"title": "Reject transaction",
"description": "Are you sure you want to reject this transaction?",
"node": "Please note that rejecting a transaction only hides it from your Activity feed"
"ignore": "Ignore",
"confirmIgnore": {
"title": "Ignore transaction",
"description": "Are you sure you want to ignore this transaction?",
"node": "Please note that ignoring a transaction only hides it from your Activity feed"
},
"confirmTokenBurn": {
"title": "Burn {assetName}",
Expand Down Expand Up @@ -1743,8 +1743,8 @@
"yes": "Yes",
"no": "No"
},
"showRejected": {
"label": "Show rejected",
"showIgnored": {
"label": "Show ignored",
"yes": "Yes",
"no": "No"
},
Expand Down