Skip to content

Conversation

@cpl121
Copy link
Contributor

@cpl121 cpl121 commented Apr 3, 2024

Closes #8301

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 linked an issue Apr 3, 2024 that may be closed by this pull request
@cpl121 cpl121 marked this pull request as ready for review April 3, 2024 21:46
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really great 🚀 also, this PR fixes the issue of claiming outputs with an expiration unlock condition in the transaction history, so I link this PR to 🙏
great job 🙌

@evavirseda evavirseda linked an issue Apr 4, 2024 that may be closed by this pull request
…'develop-iota2.0' of github.com:iotaledger/firefly into feat/update-prepared-output-unlocks-to-new-tips
@cpl121 cpl121 merged commit 18c9cfb into develop-iota2.0 Apr 4, 2024
@cpl121 cpl121 deleted the feat/update-prepared-output-unlocks-to-new-tips branch April 4, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Update prepared output unlocks to new TIPs [Task]: Claim outputs in the tx history (expiration)

5 participants