This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Adding option for dotfiles in addFromFs #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
suggested changes
Jan 11, 2017
daviddias
suggested changes
Jan 11, 2017
README.md
Outdated
| Reads a file or folder from `path` on the filesystem and adds it to IPFS. Options: | ||
| - **recursive**: If `path` is a directory, use option `{ recursive: true }` to add the directory and all its sub-directories. | ||
| - **ignore**: To exclude fileglobs from the directory, use option `{ ignore: ['ignore/this/folder/**', 'and/this/file'] }`. | ||
| - **dot**: Dotfiles (files or folders starting with a `.`, for example, `.git/`) are not included by default. To add them, use the option `{ dot: true }`. |
There was a problem hiding this comment.
go-ipfs calls these 'hidden', could you change this to 'hidden' for the sake of consistency?
* Changed `dot` option to `hidden` to match go-ipfs * Asserted hidden file hash in test for safety
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just passes through the option as specified in the glob npm module
https://www.npmjs.com/package/glob#dots