Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

chore: make sure everything is good with 0.4.5 #524

Closed
wants to merge 1 commit into from
Closed

chore: make sure everything is good with 0.4.5 #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"peer-info": "~0.8.3",
"promisify-es6": "^1.0.2",
"pump": "^1.0.2",
"qs": "^6.3.0",
"qs": "^6.3.1",
"readable-stream": "1.1.14",
"stream-http": "^2.6.3",
"streamifier": "^0.1.1",
Expand All @@ -62,15 +62,15 @@
"devDependencies": {
"aegir": "^10.0.0",
"chai": "^3.5.0",
"eslint-plugin-react": "^6.9.0",
"eslint-plugin-react": "^6.10.0",
"gulp": "^3.9.1",
"hapi": "^16.1.0",
"interface-ipfs-core": "~0.24.1",
"ipfsd-ctl": "~0.18.2",
"ipfsd-ctl": "~0.19.0",
"pre-commit": "^1.2.2",
"socket.io": "^1.7.2",
"socket.io-client": "^1.7.2",
"stream-equal": "^0.1.12"
"stream-equal": "^0.1.13"
},
"pre-commit": [
"lint",
Expand Down Expand Up @@ -124,4 +124,4 @@
"url": "https://github.com/ipfs/js-ipfs-api/issues"
},
"homepage": "https://github.com/ipfs/js-ipfs-api"
}
}
2 changes: 1 addition & 1 deletion test/ipfs-factory/daemon-spawner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function Factory () {

nodes.push(node)

callback(null, node.apiAddr)
callback(null, node.apiAddr.toString())
Copy link
Contributor Author

@daviddias daviddias Feb 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my spidey sense was tingling @haadcode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your senses were correct! I made another PR that fixes this: #525 along with adding a test to test the constructor for both Multiaddr type and a multiaddr string. Tested against ipfsd-ctl@0.19.0 and the tests pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, closing this in favour of #525 then :)

})
}

Expand Down
4 changes: 2 additions & 2 deletions test/name.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ describe('.name', () => {
expect(err).to.not.exist
expect(res).to.exist
expect(res).to.be.eql({
Path: '/ipfs/' + name.Value
Path: name.Value
})
done()
})
Expand All @@ -99,7 +99,7 @@ describe('.name', () => {
.then((res) => {
expect(res).to.exist
expect(res).to.be.eql({
Path: '/ipfs/' + name.Value
Path: name.Value
})
})
})
Expand Down