clippy

Author: rkuhn

examples/netcat_host.rs

@@ -8,20 +8,20 @@ fn main() {
         let mut netsim = Netsim::<String, String>::new();
         let net1 = netsim.spawn_network(Ipv4Range::global());
         let mut server = Command::new("ncat");
-        server.args(&["-l", "-4", "-p", "4242", "-c", "echo '<Hello World'"]);
+        server.args(["-l", "-4", "-p", "4242", "-c", "echo '<Hello World'"]);
 
         let server = netsim.spawn_machine(server, None).await;
         netsim.plug(server, net1, None).await;
         let server_addr = netsim.machine(server).addr();
-        println!("Server Addr {}:4242", server_addr.to_string());
+        println!("Server Addr {}:4242", server_addr);
 
         let _ns = Namespace::current().unwrap();
         let ns_server = netsim.machine(server).namespace();
         println!("{}", ns_server);
         netsim.machine(server).namespace().enter().unwrap();
 
         let mut cmd = Command::new("nc");
-        cmd.args(&[&*server_addr.to_string(), "4242"]);
+        cmd.args([&*server_addr.to_string(), "4242"]);
         let output = cmd.output().await.unwrap();
         println!("response: {}", std::str::from_utf8(&output.stdout).unwrap());
         //println!("error: {}", std::str::from_utf8(&output.stderr).unwrap());

nat/src/nat.rs

@@ -142,7 +142,7 @@ impl Ipv4Nat {
                             private_dest_addr,
                         );
                         packet.set_checksum();
-                        let _ = self.private_plug.unbounded_send(bytes);
+                        self.private_plug.unbounded_send(bytes);
                     } else {
                         packet.set_source(external_source_addr);
                         log::trace!(
@@ -152,7 +152,7 @@ impl Ipv4Nat {
                             external_source_addr,
                         );
                         packet.set_checksum();
-                        let _ = self.public_plug.unbounded_send(bytes);
+                        self.public_plug.unbounded_send(bytes);
                     }
                 }
             }
@@ -219,7 +219,7 @@ impl Ipv4Nat {
                             private_dest_addr,
                         );
                         packet.set_checksum();
-                        let _ = self.private_plug.unbounded_send(bytes);
+                        self.private_plug.unbounded_send(bytes);
                     } else if self.blacklist_unrecognized_addrs {
                         log::info!(
                             "nat {}: blacklisting unknown address {}.",

router/src/lib.rs

@@ -133,7 +133,7 @@ fn forward_packet(
                     log::trace!("router {}: route {:?} disabled", addr, route);
                 } else {
                     log::trace!("router {}: routing packet on route {:?}", addr, route);
-                    let _ = tx.unbounded_send(bytes.clone());
+                    tx.unbounded_send(bytes.clone());
                     forwarded = true;
                 }
             }

src/lib.rs

@@ -75,7 +75,7 @@ where
     pub async fn spawn<T: 'static + Send>(&mut self, function: &str) -> (MachineId, IpcSender<T>) {
         let (server, server_name) = IpcOneShotServer::new().unwrap();
         let mut command = Command::new(std::env::current_exe().unwrap());
-        command.args(&["--netsim-embed-internal-call", function, &server_name]);
+        command.args(["--netsim-embed-internal-call", function, &server_name]);
         let machine = self.spawn_machine(command, None).await;
         let (_, ipc) = async_global_executor::spawn_blocking(|| server.accept())
             .await