Skip to content

Another example of device support being checked later than expected #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Another example of device support being checked later than expected #1488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion netsim/modules/evpn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def register_static_transit_vni(topology: Box) -> None:
continue

for vrf_name,vrf_data in n.vrfs.items():
if vrf_data.get('evpn.transit_vni',None):
if vrf_data and vrf_data.get('evpn.transit_vni',None):
log.error(
f'evpn.transit_vni can be specified only on global VRFs (found in {vrf_name} on {n.name}',
log.IncorrectValue,
Expand Down
2 changes: 2 additions & 0 deletions tests/errors/node-unsupported-module.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
IncorrectValue in modules: Device type vmx used by node n1 is not supported by module evpn
Fatal error in netlab: Cannot proceed beyond this point due to errors, exiting
12 changes: 12 additions & 0 deletions tests/errors/node-unsupported-module.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
defaults.device: vmx
defaults.provider: clab

module: [evpn,bgp,vrf]

bgp.as: 65000

nodes:
n1:
vrfs:
test:
evpn.bundle: vlan
Loading