Fix 'when' conditions in Ansible playbooks/task lists #2764
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansible release 12 hates having non-bool expressions in 'when:' conditions, and we sloppily used 'when: string' all over the place. This commit ensures every expression used in a 'when' condition is a true bool and uses 'when: x is string and x != ""' expression instead of 'when: x' (adding 'x is string' because the Ansible documentation is confusing enough that I don't trust what exactly they might do in a future release)
jbemmel
approved these changes
Oct 28, 2025
You're describing my usual Ansible experience 🤷♂️🤦♂️ |
|
Wont a suffix of | bool fix this in a cleaner way? |
That was my first though, but then I landed on the "I don't think this word means what you think it means" island: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/bool_filter.html The test to use would be "is truthy": https://docs.ansible.com/ansible/latest/collections/ansible/builtin/truthy_test.html |
|
TIL! |
🤷♂️ Personal preference (that has absolutely nothing to do with me hating a certain product that made me rewrite my code way too many times) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible release 12 hates having non-bool expressions in 'when:' conditions, and we sloppily used 'when: string' all over the place.
This commit ensures every expression used in a 'when' condition is a true bool and uses 'when: x is string and x != ""' expression instead of 'when: x' (adding 'x is string' because the Ansible documentation is confusing enough that I don't trust what exactly they might do in a future release)