casting traits inherit from mixin#299
Closed
rmorshea wants to merge 1 commit intoipython:masterfrom
Closed
Conversation
59d1083 to
0d7a5f0
Compare
0d7a5f0 to
01666da
Compare
| cast_to = None | ||
|
|
||
| def validate(self, obj, value): | ||
| cast_types = getattr(self, '_cast_types', All) |
Member
There was a problem hiding this comment.
This can be defined as the default on the mixin, rather than using getattr with a falllback
Contributor
Author
|
Working on a more generic solution... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a generic
CastingMixinclass that all other castingTraitTypesinherit from (i.e.CInt,CFloat, etc.). Upon setting a value, these reconfigured traits first coerce the input value to the proper type, and then pass it tosuper().validate(...). This mixin also makes new casting traits likeCDictandCListmore sensible to implement, because the complex base class validation heuristics don't need to be hard coded in their casting versions anymore: