invert class/instance initialize priority in union "subtraits"#346
Closed
rmorshea wants to merge 5 commits intoipython:masterfrom
Closed
invert class/instance initialize priority in union "subtraits"#346rmorshea wants to merge 5 commits intoipython:masterfrom
rmorshea wants to merge 5 commits intoipython:masterfrom
Conversation
rmorshea
changed the title
Member
|
Merged as c523781 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unionvalidation prefers the first givenTraitTypeso it seems reasonable to remain consistent and prefer the default value of that firstTraitTypeas well.Right now, we prefer the default value of the last given
TraitTypewhich seems odd since that default will first have to pass validation from all theTraitTypesbefore it.