Skip to content

test union valdiation priority#347

Merged
minrk merged 1 commit intoipython:masterfrom
rmorshea:union_validation_priority
Dec 21, 2016
Merged

test union valdiation priority#347
minrk merged 1 commit intoipython:masterfrom
rmorshea:union_validation_priority

Conversation

@rmorshea
Copy link
Copy Markdown
Contributor

@rmorshea rmorshea commented Nov 11, 2016 •
edited
Loading 

class Foo(HasTraits):
    bar = Union([CInt(), Unicode()])
foo = Foo()
foo.bar = '1'
# validation in order of the TraitTypes given
assert foo.bar == 1

@rmorshea rmorshea mentioned this pull request Nov 11, 2016
Closed
@rmorshea rmorshea force-pushed the union_validation_priority branch from 94b5fdf to 3cff579 Compare November 21, 2016 19:29
@rmorshea rmorshea force-pushed the union_validation_priority branch from 3cff579 to 2bcb993 Compare November 21, 2016 19:30
@rmorshea
Copy link
Copy Markdown
Contributor Author

rmorshea commented Nov 21, 2016

@minrk rebased.

minrk
minrk reviewed Nov 21, 2016
View reviewed changes
Comment thread .cache/v/cache/lastfailed
@@ -0,0 +1 @@
{} No newline at end of file
Copy link
Copy Markdown
Member

@minrk minrk Nov 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this got added by accident

@minrk minrk added this to the 5.0 milestone Nov 22, 2016
@minrk minrk merged commit 9f5a75f into ipython:master Dec 21, 2016
@Carreau Carreau added 5.0-re-review Need to re-review for potential API impact changes. 5.0-no-incidence change that has noincidence on 5.0 compat (eg: doc) and removed 5.0-re-review Need to re-review for potential API impact changes. labels Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minrk minrk minrk left review comments

Assignees

No one assigned

Labels

5.0-no-incidence change that has noincidence on 5.0 compat (eg: doc)

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@rmorshea @minrk @Carreau