FIX: KVConfigLoader could not handle lone dashes('-') as extra arguments#365
Merged
minrk merged 6 commits intoipython:masterfrom Jan 30, 2017
Merged
FIX: KVConfigLoader could not handle lone dashes('-') as extra arguments#365minrk merged 6 commits intoipython:masterfrom
minrk merged 6 commits intoipython:masterfrom
Conversation
Contributor
Author
|
Added a rather unrelated commit for site-docs: |
minrk
reviewed
Jan 30, 2017
| if not item: | ||
| # I.e. it was a lone '-' used for denoting STDIN, or '---'. | ||
| self.extra_args.append('-') | ||
| continue |
Contributor
Author
There was a problem hiding this comment.
Yes, duplicate code.
Also previously was replacing user-arg always with '-' - now adds user-arg verbatim, even if it is 3 or more dashes concatenated.
Carreau
added
5.0-re-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeyValueConfigLoader.load_config()was considering lone dash(-) args as invalids(these are frequently used to denote STDIN).