notify on default creation#383
Merged
minrk merged 2 commits intoipython:masterfrom Mar 28, 2017
Merged
Conversation
a52eb12 to
9b6e011
Compare
9b6e011 to
90778ef
Compare
Member
|
This has broken widgets because it calls notify_change with events that are not change events. We either need to ensure that these events are supersets of change events, or trigger a different call that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notify upon the creation of a default value. The current scheme for this event report is:
{ 'name': <the trait's name>, 'owner': <it's HasTraits object>, 'value': <default value> 'type': 'default', }A Possible Use Case
A
@go_betweendecorator that effectively turns traits into properties, but still has the added benefits oftraitletsvalidation.