Skip to content

TST: Improve branch length testing #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2025
Merged

TST: Improve branch length testing #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca4bd7d
MAINT: Correct changleog
rmcar17 Jul 19, 2025
ad488f1
Merge branch 'main' into main
rmcar17 Jul 19, 2025
2596cd1
TST: Improve branch length testing in preparation for TreeNode deprec…
rmcar17 Jul 31, 2025
8b45b72
Merge branch 'iqtree:main' into main
rmcar17 Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/test_iqtree/test_build_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,10 @@ def check_build_tree_model(
expected = make_tree("(Human,Chimpanzee,(SpermWhale,HumpbackW));")

got = piqtree.build_tree(aln, str(model) if coerce_str else model)

# Check topology
assert expected.same_topology(got.unrooted())
# Check if branch lengths exist
assert all("length" in v.params for v in got.get_edge_vector())
assert all(v.length is not None for v in got.get_edge_vector(include_root=False))


def check_build_tree(
Expand Down
3 changes: 1 addition & 2 deletions tests/test_iqtree/test_protein_build_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@ def check_build_tree_model(
coerce_str: bool = False,
) -> None:
got = piqtree.build_tree(aln, str(model) if coerce_str else model, rand_seed=1)

# Check if all branch lengths exist
assert all("length" in v.params for v in got.get_edge_vector())
assert all(v.length is not None for v in got.get_edge_vector(include_root=False))


def check_build_tree(
Expand Down