Fix Switches.All and implement Switches.Active (#44)

Author: GrigoriyMikhalkin

cmdutils/switches/switches.go

@@ -121,13 +121,25 @@ func (s *Switches) Enabled(name string) bool {
 // All returns names of all items set in settings
 func (s *Switches) All() sets.String {
 	names := sets.NewString()
-	for k := range s.settings {
+	for k := range s.defaults {
 		names.Insert(k)
 	}
 
 	return names
 }
 
+// Active returns names of all active items
+func (s *Switches) Active() sets.String {
+	names := sets.NewString()
+	for k, enabled := range s.settings {
+		if enabled {
+			names.Insert(k)
+		}
+	}
+
+	return names
+}
+
 // EnabledByDefault returns names of all enabled items
 func (s *Switches) EnabledByDefault() sets.String {
 	names := sets.NewString()

cmdutils/switches/switches_test.go

@@ -31,12 +31,19 @@ var _ = Describe("CMD Switches", func() {
 			Expect(s.Enabled("runner-b")).To(BeFalse())
 		})
 		It("should return all items", func() {
-			s := New("runner-a", "runner-b")
+			s := New("runner-a", "runner-b", Disable("runner-c"))
 			Expect(s.Set("*,-runner-b")).ToNot(HaveOccurred())
 
-			expected := sets.NewString("runner-a", "runner-b")
+			expected := sets.NewString("runner-a", "runner-b", "runner-c")
 			Expect(s.All()).To(Equal(expected))
 		})
+		It("should return only active items", func() {
+			s := New("runner-a", "runner-b", Disable("runner-c"))
+			Expect(s.Set("*,-runner-b")).ToNot(HaveOccurred())
+
+			expected := sets.NewString("runner-a")
+			Expect(s.Active()).To(Equal(expected))
+		})
 		It("should return all enabled items", func() {
 			s := New("runner-a", Disable("runner-b"))