Skip to content

Fix installation of apiservice in Makefile #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2024
Merged

Fix installation of apiservice in Makefile #228

merged 2 commits into from
Feb 2, 2024

Conversation

@Rohit-0505
Copy link
Contributor

@Rohit-0505 Rohit-0505 commented Feb 2, 2024 •
edited
Loading

  • remove target for installation of crds in Makefile
  • add target for apiservice installation in Makefile
  • fix path for ironcore-net controller manager deployment
  • fix target to undeploy ironcore-net metalnetlet and apinetlet controllers

Fixes #227

@Rohit-0505 Rohit-0505 requested a review from a team as a code owner February 2, 2024 04:46
@github-actions github-actions bot added bug Something isn't working size/M labels Feb 2, 2024
@afritzler afritzler merged commit cc8b29a into main Feb 2, 2024
@afritzler afritzler deleted the apiservice-installation branch February 2, 2024 08:09
@hardikdr hardikdr added the area/networking Networking-related tasks and improvements. label Jun 25, 2025
@hardikdr hardikdr added this to Roadmap Jun 29, 2025
@hardikdr hardikdr moved this to Done in Roadmap Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

No one assigned

Labels

area/networking Networking-related tasks and improvements. bug Something isn't working size/M

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix installation of apiservice in Makefile

4 participants

@Rohit-0505 @afritzler @hardikdr