Skip to content

Fix NATReconciler to modify NATTable of NIC belonging to NATs Network #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2024
Merged

Fix NATReconciler to modify NATTable of NIC belonging to NATs Network #241

merged 3 commits into from
Feb 19, 2024

Conversation

@kasabe28
Copy link
Contributor

@kasabe28 kasabe28 commented Feb 13, 2024 •
edited
Loading

Proposed Changes

  • Modify NATTable logic to list all in-namespace NICs belonging to NATs Network
  • Modify NATReconciler test to create network without NAT and NIC referring to without NAT network. And validate result to have only NAT Network NIC to be in NATTable.

Fixes #181

@kasabe28 kasabe28 requested a review from a team as a code owner February 13, 2024 09:20
@github-actions github-actions bot added size/M bug Something isn't working labels Feb 13, 2024
afritzler
afritzler requested changes Feb 14, 2024
View reviewed changes
@kasabe28 kasabe28 requested a review from afritzler February 15, 2024 12:01
afritzler
afritzler requested changes Feb 18, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some cosmetics. Apart from that the PR looks good.

@kasabe28 kasabe28 requested a review from afritzler February 19, 2024 10:16
@afritzler afritzler merged commit 55efdc9 into main Feb 19, 2024
@afritzler afritzler deleted the fix/NATReconciler branch February 19, 2024 21:37
@afritzler afritzler mentioned this pull request Sep 26, 2024
Closed
@hardikdr hardikdr added the area/networking Networking-related tasks and improvements. label Jun 25, 2025
@hardikdr hardikdr added this to Roadmap Jun 29, 2025
@hardikdr hardikdr moved this to Done in Roadmap Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

No one assigned

Labels

area/networking Networking-related tasks and improvements. bug Something isn't working size/M

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NATReconciler should only modify the NATTable of NetworkInterfaces belonging to the NATs networkRef

4 participants

@kasabe28 @afritzler @hardikdr