Update network concept doc with network peering #256
Conversation
github-actions
bot
added
size/S
documentation
| `spec.peerings` referencing each other respectively. A `ironcore` `Network` can be peered with | ||
| multiple `network`s in any namespcae. | ||
|
|
||
| Once specified `apinetlet` `NetworkPeeringController` validates if all the specified `network`s are in |
There was a problem hiding this comment.
Do we really need an own reconciler for the Network peering or wouldn't it be just enough to extend the existing Network reconciler to ensure the peering information in the Network in the apinet group and update the ironcore Status once the peering was established.
There was a problem hiding this comment.
Network peering is happening only with Available state networks, so I think we should have different reconciler for network peering. If we do it in existing Network controller we have to wait till both networks come Available and then do peering in same reconcile loop will not be possible.
@balpert89 do you have different thoughts for new controller?
There was a problem hiding this comment.
Yes my suggestion was to separate this in a dedicated controller because of two reasons:
- what happens when the peering partner network has not set the currently reconciling network in its peering reference? The reconcile request has to be requeued then and can block succeeding the loop for this particular network (and its partner). If the logic for peering is isolated in its own controller, the "normal" reconciliation can happen without changing its logic.
- as @kasabe28 mentioned, the reconciliation should only happen once the network status is
Availablewhich is contradicting to the current network reconciler as this one is actually setting the status toAvailable.
| `spec.peeredIDs` with valid peered network's `providerID`'s. | ||
|
|
||
| Once `ironcore-net` `Network` is updated with `spec.peeredIDs`, `metalnetlet` `NetworkController` | ||
| updates `metalnet` `Network` `spec.peeredIDs` with corresponding `ironcore-net` `Network` `spec.peeredIDs` |
There was a problem hiding this comment.
Regarding the peering status I opened an issue in the the metalnet project to clarify if we actually can get any status information: ironcore-dev/metalnet#189
Proposed Changes
Fixes #