Skip to content

Add partition wise network peering status in apinet Network resource #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 11, 2024
Merged

Add partition wise network peering status in apinet Network resource #327

merged 5 commits into from
Oct 11, 2024

Conversation

@kasabe28
Copy link
Contributor

@kasabe28 kasabe28 commented Sep 19, 2024 •
edited
Loading

Proposed Changes

  • Modify NetworkPeeringStatus type to have partition wise peering status
  • Modify metalnetlet NetworkController to update partition wise peering status in apinet Network
  • Modify apinet NetworkController to aggregate partition wise peering status and update ironcore Network status accordingly.
  • Patch network spec and status only when its changed
  • Modify relevant tests
  • Modify relevant api-docs

Fixes #

@github-actions github-actions bot added bug Something isn't working size/L labels Sep 19, 2024
@kasabe28 kasabe28 force-pushed the fix/network-status-flapping branch 2 times, most recently from 19e3732 to b0b74d6 Compare September 23, 2024 07:58
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 1, 2024
@kasabe28 kasabe28 self-assigned this Oct 1, 2024
@kasabe28 kasabe28 changed the title Patch network spec and status only when its changed Add partition wise network peering status in apinet Network resource Oct 3, 2024
@kasabe28 kasabe28 marked this pull request as ready for review October 3, 2024 05:53
@kasabe28 kasabe28 requested a review from a team as a code owner October 3, 2024 05:53
@Rohit-0505 Rohit-0505 force-pushed the fix/network-status-flapping branch from 3e049c2 to ee0a8ff Compare October 7, 2024 06:56
@afritzler afritzler merged commit 6de703a into main Oct 11, 2024
11 checks passed
@afritzler afritzler deleted the fix/network-status-flapping branch October 11, 2024 09:27
@hardikdr hardikdr added the area/networking Networking-related tasks and improvements. label Jun 25, 2025
@hardikdr hardikdr added this to Roadmap Jun 29, 2025
@hardikdr hardikdr moved this to Done in Roadmap Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@kasabe28 kasabe28

Labels

area/networking Networking-related tasks and improvements. bug Something isn't working documentation Improvements or additions to documentation size/L

Projects

IaaS
Status: ✅ Done
Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kasabe28 @afritzler @hardikdr