Add missing claimRef in ephemeral IP allocation
#364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
pending draft to check if https://github.com/ironcore-dev/ironcore-net/blob/main/internal/registry/loadbalancer/storage.go#L156 has to point to the ironcore-net GVK instead. |
Contributor
Author
as agreed will open a dedicated PR for that. |
afritzler
approved these changes
Jan 29, 2025
afritzler
changed the title
claimRef in ephemeral IP allocation
Member
|
@balpert89 thanks a lot for providing this fix! Can you please rebase the PR branch? |
lukas016
force-pushed
the
osc/fix-missing-ip-claims
branch
from
6048e3e to
50520e7
Compare
Contributor
Author
|
@afritzler rebase done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #363