Skip to content

Introduce node affinity awareness for apinet loadbalancers #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 16, 2025
Merged

Introduce node affinity awareness for apinet loadbalancers #414

merged 9 commits into from
Jun 16, 2025

Conversation

@balpert89
Copy link
Contributor

@balpert89 balpert89 commented Jun 9, 2025

Fixes #413

@balpert89 balpert89 requested a review from a team as a code owner June 9, 2025 16:20
@github-actions github-actions bot added the size/M label Jun 9, 2025
balpert89 added 4 commits June 9, 2025 21:28
@balpert89
introduce flag for node affinity awareness & extract destination prep…
07d1981 
…aration

Signed-off-by: Benjamin Alpert <benjamin.alpert@t-systems.com>
@balpert89
apply node affinity configuration when node affinity awareness is ena…
7047bc0 
…bled

Signed-off-by: Benjamin Alpert <benjamin.alpert@t-systems.com>
@balpert89
remove unused return val
c7620cf 
Signed-off-by: Benjamin Alpert <benjamin.alpert@t-systems.com>
@balpert89
fix duplicate import
32a73c4 
Signed-off-by: Benjamin Alpert <benjamin.alpert@t-systems.com>
@balpert89 balpert89 added enhancement New feature or request area/networking Networking-related tasks and improvements. labels Jun 9, 2025
@balpert89 balpert89 marked this pull request as draft June 9, 2025 19:53
@github-actions github-actions bot added size/L and removed size/M labels Jun 9, 2025
@balpert89 balpert89 assigned balpert89 and unassigned afritzler Jun 9, 2025
@balpert89 balpert89 marked this pull request as ready for review June 9, 2025 20:17
@balpert89 balpert89 marked this pull request as draft June 10, 2025 08:00
@github-actions github-actions bot added size/M and removed size/L labels Jun 10, 2025
@balpert89 balpert89 marked this pull request as ready for review June 10, 2025 12:06
@balpert89 balpert89 mentioned this pull request Jun 11, 2025
Closed
@afritzler afritzler added the area/iaas Issues related to IronCore IaaS development. label Jun 11, 2025
@afritzler afritzler self-requested a review June 11, 2025 11:36
afritzler
afritzler requested changes Jun 13, 2025
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extend the test suite with a SetupTestWithAntiaffinity() and ensure the correct behavior with a unit test?

@github-actions github-actions bot added size/L and removed size/M labels Jun 16, 2025
@balpert89
Copy link
Contributor Author

balpert89 commented Jun 16, 2025

Can we extend the test suite with a SetupTestWithAntiaffinity() and ensure the correct behavior with a unit test?

added with 3a8a1d3

@afritzler afritzler merged commit 153c318 into ironcore-dev:main Jun 16, 2025
8 checks passed
@hardikdr hardikdr added this to Roadmap Jun 29, 2025
@hardikdr hardikdr moved this to Done in Roadmap Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@balpert89 balpert89

Labels

area/iaas Issues related to IronCore IaaS development. area/networking Networking-related tasks and improvements. enhancement New feature or request size/L

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

when creating the Loadbalancer resource the apinetlet should have an optional instruction to inject node affinity alongside the anti affinity

2 participants

@balpert89 @afritzler