Skip to content

Add predicates to prevent unnecessary NIC reconciliation triggers #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

Add predicates to prevent unnecessary NIC reconciliation triggers #424

merged 1 commit into from
Aug 5, 2025

Conversation

@sujeet01
Copy link
Contributor

@sujeet01 sujeet01 commented Jul 28, 2025 •
edited
Loading

Proposed Changes

  • Add a predicate to ignore Node heartbeat updates (lastHeartbeatTime) that were unnecessarily triggering NIC reconciliations
  • Add a predicate to reconcile NIC for spec/status updates
  • Rename functions to accurately reflect that they watch regular k8s corev1.Node, not metalnetv1alpha1.Node
  • Remove redundant code

Fixes #423

@sujeet01 sujeet01 self-assigned this Jul 28, 2025
@github-actions github-actions bot added size/M bug Something isn't working labels Jul 28, 2025
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/fix/optimize-nic-reconciles-with-predicates branch from 2976811 to 8dd53fb Compare July 28, 2025 18:49
@hardikdr hardikdr added the area/networking Networking-related tasks and improvements. label Jul 29, 2025
@hardikdr hardikdr added this to Roadmap Jul 29, 2025
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/fix/optimize-nic-reconciles-with-predicates branch from 8dd53fb to ab9600d Compare July 29, 2025 09:50
@sujeet01 sujeet01 marked this pull request as ready for review July 29, 2025 12:49
@sujeet01 sujeet01 requested a review from a team as a code owner July 29, 2025 12:49
@sujeet01 sujeet01 marked this pull request as draft July 29, 2025 14:39
@opensovereigncloud-user opensovereigncloud-user force-pushed the osc/fix/optimize-nic-reconciles-with-predicates branch from ab9600d to bd1b64e Compare July 31, 2025 07:20
@sujeet01 sujeet01 marked this pull request as ready for review August 1, 2025 05:55
@balpert89 balpert89 merged commit 544379c into ironcore-dev:main Aug 5, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this to Done in Roadmap Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afritzler afritzler afritzler approved these changes

@balpert89 balpert89 balpert89 approved these changes

Assignees

@sujeet01 sujeet01

Labels

area/networking Networking-related tasks and improvements. bug Something isn't working size/M

Projects

Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unnecessary NetworkInterface reconciliations triggered by Node heartbeat updates

4 participants

@sujeet01 @afritzler @balpert89 @hardikdr