Limit is overruled by paginate

[matthijsgroen]

When I just want the 2 first unstarted stories, I get all of them. I think it is because the limit I set is overruled by the paginate method of the endpoint.

[forest]

Thanks for the report. That could be the case. I'll have to do some
investigation.

Pull requests and updates to the specs are always welcome.

[forest]

@matthijsgroen I was able to reproduce what you are seeing. If you turn auto pagination off when you create the client the limit works as you expected. The problem is that the limit when auto pagination is enabled is telling the API to paginate in limit sized chunks. Both behaviors are useful so I make it possible to pass auto_paginate: false per request for time when you want a small subset of the results.

stories = project.stories(limit: 7, auto_paginate: false)

[matthijsgroen]

Thanks! That would indeed solve my problem

Op zondag 19 oktober 2014 heeft Forest notifications@github.com het
volgende geschreven:

Closed #13 #13 via
c7e606a
c7e606a
.

—
Reply to this email directly or view it on GitHub
#13 (comment).

[bartoszkopinski]

@forest this behaviour is confusing since there is no mention of auto_paginate in the readme but it is enabled by default.

Additionally, limit option is mentioned but will not work by default like this:

project.stories(with_state: :unscheduled, limit: 10) # Get 10 unscheduled stories for a project

This will by default return all stories.

I think auto_paginate should be disabled automatically if limit is provided.