[Bug] MC-168573 Fix breaks shield blocking sounds

[cintlep]

Bug Description

When this fix is enabled, clients will receive fake damage and play the player hurt sound if the player gets attacked by any mob. Its supposed to play the blocking sound, and not cause any damage tilt. This behavior doesn't occur with this fix disabled.

How to Reproduce?

1. Go into world with fix enabled
2. Get a shield and start blocking
3. Any melee mob or projectile mob to attack you
4. Notice the sounds and fake damage event you receive

Expected Behavior

The shield would play the proper blocking noise, and no damage bob when blocking an attack

Version

1.21.8+1.0

Fabric/Quilt Loader Version

0.16.14 for 1.21.7

Logs or additional context

No response

Has not been reported.

• I made sure this bug hasn't already been reported.

Is on most update to date version.

• I made sure I am using the most up to date fabric/quilt loader and mod version.

[MicrocontrollersDev]

Looks like this is on me, misunderstood what the hurtAndBreak method does (I thought it was break as in actually break but no, just take damage). I think wrapping the stopUsingItem in a itemStack.isBroken call or similar should be enough (and a shift.AFTER so the break method is actually called). can PR this tomorrow when I have time if Xander or no one else gets to it

[leftbones]

This issue is still occurring in the latest mod version 1.21.8+1.0 on Modrinth and Fabric version 1.21.8, I saw the fix got merged but has that fix not made it to the release version yet?

[MicrocontrollersDev]

This issue is still occurring in the latest mod version 1.21.8+1.0 on Modrinth and Fabric version 1.21.8, I saw the fix got merged but has that fix not made it to the release version yet?

correct, until xander releases a new versions you can download the jar from the actions artifact: https://github.com/isXander/Debugify/actions/runs/16599305283/artifacts/3639899290