Skip to content

Conversation

yijieg
Copy link
Collaborator

@yijieg yijieg commented Oct 9, 2025

Description

  • Fixes the warning messages reported in the QA testing
  • Remove redundant config argument 'sample_from'
  • Change the default value of config argument 'num_log_traj'

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@yijieg yijieg requested a review from kellyguo11 as a code owner October 9, 2025 21:58
@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Oct 9, 2025
Copy link

github-actions bot commented Oct 10, 2025

Test Results Summary

2 547 tests   2 087 ✅  2h 30m 4s ⏱️
   96 suites    460 💤
    1 files        0 ❌

Results for commit c2d74ff.

♻️ This comment has been updated with latest results.

@kellyguo11 kellyguo11 changed the title Fix warnings when running AutoMate env Fixes warnings when running AutoMate env Oct 13, 2025
@kellyguo11 kellyguo11 merged commit 2d80bd8 into main Oct 14, 2025
11 checks passed
@kellyguo11 kellyguo11 deleted the dev/automate_warning branch October 14, 2025 22:06
kellyguo11 added a commit that referenced this pull request Oct 15, 2025
# Description

* Fixes the warning messages reported in the QA testing
* Remove redundant config argument 'sample_from'
* Change the default value of config argument 'num_log_traj'

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

---------

Co-authored-by: Kelly Guo <kellyg@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants