Move account create and update endpoints to RTKQ #1816
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates new RTKQ endpoints for user creation and updates. This replaces the
createUserandupdateUserasync thunks. Most of the logic from there has been moved into theonQueryStartedlifecycle method of their respectivequeries. The email change confirmation logic was moved out of there and into the My Account component, seeing as that's the only place it is used.
Components that used
createUser/updateUsernow use the generated RTKQ hook instead, and use its error handling instead ofgeneralErrors. I have also addedExigentErrors to surface these where needed.This affects a few different flows:
Registration and LLM questions have E2E test coverage. If the reviewer feels strongly about adding automated tests for the update flows we can do that, and that is probably sensible, but we don't currently have much in those areas so it would be a non-trivial amount of effort. Short of that I have manually tested thoroughly.