RTKQ Migration: Site search #1826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was toying between using debounce and throttle here, but went with a debounce with both leading and trailing set. This makes it instantly responsive on first use, but waits until the timeout has passed entirely once if there are multiple presses. Truthfully this probably doesn't *need* a debounce here since it's unlikely someone would spam enter alongside typing their query, but it doesn't hurt.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1826 +/- ##
==========================================
+ Coverage 41.73% 42.08% +0.35%
==========================================
Files 542 542
Lines 23685 23670 -15
Branches 7855 6998 -857
==========================================
+ Hits 9884 9961 +77
+ Misses 13757 13664 -93
- Partials 44 45 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axlewin
reviewed
Nov 13, 2025
Contributor
axlewin
left a comment
axlewin
left a comment
There was a problem hiding this comment.
The search logic looks good, as does the main search page.
This breaks header search, though, where onSearch isn't defined.
axlewin
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the site search logic to RTKQ.