Only show empty states if loaded #1831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set Assignments: on Ada particularly, a big yellow warning appears for a fraction of a scond while loading Set Assignments currently, as the empty state box appears while the query is loading. While I would like to replace this entire file with a
<ShowLoadingQuery/>where we can make use of placeholders, since we have this as is it is much easier to simply adjust the logic not to show these empty states if groups/boards are undefined.User search: "no results" particularly noticeable during postcode search on a large group. Now shows the
<Loading/>component.