add Error Handling & cleanup

[dominictarr]

you need this stuff as well.

Also, two other small corrections, return dest, and check written === false instead of !written
which is consistent with the current pipe, and documentation.

with this stuff in the pipe is about the same length,
I suggest we just test for read()

if ('function' === typeof source.read) {
  //use read() still piping
  ...
} else {
  //use ondata style
  ...
}

best of both worlds

[stagas]

Shouldn't it be if (written === false) { ?

[dominictarr]

oh, your right. fixed in a17850dd4ef3d86ba2f062a91f3a5300a4b1b4b6

[isaacs]

Only 'end' means "no more bytes are coming so stop reading". "close" means "the underlying resource is disposed of" but there may be more bytes in the buffer. For example, if a fs stream has a buffering window of 16kb, but closes the fd as soon as it stops getting more stuff; the fd is now closed, but the stream isn't ended, because read() can still give you more data.

For errors, they should be handled at every step along the way, by the code that touches that stream.

So, I think this is not really necessary.