Skip to content

Conversation

@billiegoose
Copy link
Member

BREAKING CHANGE: The newSubmoduleBehavior parameter has been removed and is now the default and only behavior, because it is good. And the noSubmodules parameter has been removed and is also the default and only behavior. (This only affects you if you a) liked seeing the console warnings or b) were using statusMatrix to traverse submodules for some reason.)

@billiegoose billiegoose changed the base branch from master to beta February 14, 2020 18:15
@billiegoose billiegoose changed the title Chore/beta remove no submodules chore: make newSubmoduleBehavior and noSubmodules the default behavior Feb 14, 2020
@isomorphic-git-bot
Copy link

Thank you wmhilton! I auto-formatted the code using prettier-standard. 🤖

@karma-pr-reporter
Copy link

Test Results for 063a7f9:

Browser Pass Skip Fail Time Disconnect?
Chrome 79.0.3945 (Windows 10 0.0.0) 360 1 0 2m:56s false
Chrome Mobile 78.0.3904 (Android 0.0.0) 360 1 0 1m:39s false
Firefox 72.0.0 (Ubuntu 0.0.0) 360 1 0 0m:42s false
HeadlessChrome 0.0.0 (Linux 0.0.0) 360 1 0 0m:32s false
Mobile Safari 13.0.0 (iOS 13.0.0) 360 1 0 2m:5s false
Safari 13.0.3 (Mac OS X 10.15.1) 360 1 0 2m:6s false

Longest running tests

  • 6.613 secs - fetch fetch --prune from git-http-mock-server - Chrome
  • 5.811 secs - fetch fetch --prune-tags from git-http-mock-server - Safari
  • 5.467 secs - statusMatrix statusMatrix with filter - Chrome
  • 5.455 secs - Hosting Providers GitHub push - Chrome
  • 4.897 secs - walk can populate type, mode, oid, and content - Chrome
  • 4.583 secs - status status - Chrome
  • 4.579 secs - merge merge 'delete-first-half' and 'delete-second-half' (noUpdateBranch) - Chrome
  • 4.567 secs - merge merge two branches that modified the same file (no conflict)' - Chrome
  • 4.449 secs - fetch shallow fetch (from Github) - Mobile Safari
  • 4.248 secs - Hosting Providers GitHub push - Safari
  • 4.186 secs - statusMatrix statusMatrix - Chrome

@billiegoose billiegoose merged commit 9cd7f3d into beta Feb 14, 2020
@billiegoose billiegoose deleted the chore/beta-remove-noSubmodules branch February 14, 2020 18:41
@isomorphic-git-bot
Copy link
Member

🎉 This PR is included in version 1.0.0-beta.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

@isomorphic-git-bot
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants