Skip to content

Extend VS.HTTPRoute with RegexRewrite #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Extend VS.HTTPRoute with RegexRewrite #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions kubernetes/customresourcedefinitions.gen.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions networking/v1alpha3/virtual_service.gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,9 @@
"description": "rewrite the Authority/Host header with this value.",
"type": "string",
"format": "string"
},
"uriRegex": {
"$ref": "#/components/schemas/istio.networking.v1alpha3.UriRegexRewrite"
}
}
},
Expand Down Expand Up @@ -663,6 +666,19 @@
}
]
},
"istio.networking.v1alpha3.UriRegexRewrite": {
"type": "object",
"properties": {
"pattern": {
"type": "string",
"format": "string"
},
"substitution": {
"type": "string",
"format": "string"
}
}
},
"istio.networking.v1alpha3.HTTPFaultInjection.Delay": {
"description": "Delay specification is used to inject latency into the request forwarding path. The following example will introduce a 5 second delay in 1 out of every 1000 requests to the \"v1\" version of the \"reviews\" service from all pods with label env: prod",
"type": "object",
Expand Down
577 changes: 439 additions & 138 deletions networking/v1alpha3/virtual_service.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

48 changes: 47 additions & 1 deletion networking/v1alpha3/virtual_service.pb.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions networking/v1alpha3/virtual_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1470,6 +1470,16 @@ message HTTPRewrite {

// rewrite the Authority/Host header with this value.
string authority = 2;

// uri_regex can be used for rewriting portions of path that match the
// pattern during forwarding the request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// pattern during forwarding the request
// pattern when forwarding the request.

// RE2 style regex-based match (https://github.com/google/re2/wiki/Syntax).
UriRegexRewrite uri_regex = 3;
}

message UriRegexRewrite {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using same parameter names as envoy: https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/route/route_components.proto#envoy-api-field-route-routeaction-regex-rewrite

string pattern = 1;
string substitution = 2;
}

// Describes how to match a given string in HTTP headers. Match is
Expand Down
21 changes: 21 additions & 0 deletions networking/v1alpha3/virtual_service_deepcopy.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions networking/v1alpha3/virtual_service_json.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions networking/v1beta1/virtual_service.gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,9 @@
"description": "rewrite the Authority/Host header with this value.",
"type": "string",
"format": "string"
},
"uriRegex": {
"$ref": "#/components/schemas/istio.networking.v1beta1.UriRegexRewrite"
}
}
},
Expand Down Expand Up @@ -663,6 +666,19 @@
}
]
},
"istio.networking.v1beta1.UriRegexRewrite": {
"type": "object",
"properties": {
"pattern": {
"type": "string",
"format": "string"
},
"substitution": {
"type": "string",
"format": "string"
}
}
},
"istio.networking.v1beta1.HTTPFaultInjection.Delay": {
"description": "Delay specification is used to inject latency into the request forwarding path. The following example will introduce a 5 second delay in 1 out of every 1000 requests to the \"v1\" version of the \"reviews\" service from all pods with label env: prod",
"type": "object",
Expand Down
Loading