Skip to content

add locality label #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

add locality label #3598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b0e093
add locality label
zirain Nov 4, 2025
f89ea3f
update example
zirain Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions label/labels.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions label/labels.pb.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions label/labels.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,16 @@ labels:
resources:
- Pod

- name: topology.istio.io/locality
featureStatus: Alpha
description: This label is applied to a workload internally that indicates the region/zone/subzone of an instance.
It is used to override the native registry's value. Kubernetes labels does not support `/`, use `.` instead in kubernetes.
Copy link
Contributor

@keithmattix keithmattix Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be an example value so users know e.g how to set a region and zone at the same time

Copy link
Member Author

@zirain zirain Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

e.g. `regionA.zoneB.subZoneC`
hidden: false
deprecated: false
resources:
- Pod

- name: sidecar.istio.io/inject
featureStatus: Beta
description: Specifies whether or not an Envoy sidecar should be automatically
Expand Down