uri should be under http.match rather than under http.match.headers according to the spec of HTTPMatchRequest. #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccording to the spec of HTTPMatchRequest.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: idouba Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
rshriram
approved these changes
Jun 15, 2018
|
/ok-to-test |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In [HTTPMatchRequest ] (https://preliminary.istio.io/docs/reference/config/istio.networking.v1alpha3/#HTTPMatchRequest) , a http match can be described by uri(StringMatch), schema(StringMatch), headers map<string, StringMatch>(StringMatch) ... . uri is a brother filed of http.match.headers , not a key of headers map. It is a little confusing to use uri as a key of headers map, even though syntax is ok.