Skip to content

Hosts are not ignored in ServiceEntry for HTTPs #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 10, 2019
Merged

Hosts are not ignored in ServiceEntry for HTTPs #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
458afed
Hosts are not ignored in ServiceEntry for HTTPs
andraxylia Mar 5, 2019
cbf1c02
Clarify
andraxylia Mar 5, 2019
82632f4
Reword
andraxylia Mar 7, 2019
b50f39e
Generate protos
andraxylia Mar 8, 2019
da82fd1
Address code review comments
andraxylia Mar 8, 2019
4d8572d
Fix typo
andraxylia Mar 8, 2019
2d49f1c
generate
andraxylia Mar 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions networking/v1alpha3/service_entry.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 10 additions & 8 deletions networking/v1alpha3/service_entry.pb.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 10 additions & 8 deletions networking/v1alpha3/service_entry.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,18 +339,20 @@ option go_package = "istio.io/api/networking/v1alpha3";

message ServiceEntry {
// REQUIRED. The hosts associated with the ServiceEntry. Could be a DNS
// name with wildcard prefix (external services only). DNS names in hosts
// will be ignored if the application accesses the service over non-HTTP
// protocols such as mongo/opaque TCP/HTTPS. In such scenarios, the
// IP addresses specified in the Addresses field or the port will be used
// to uniquely identify the destination.
// name with wildcard prefix (external services only). For HTTP traffic
// the HTTP Host/Authority header will be matched against the hosts field.
// For HTTPs or TLS traffic containing Server Name Indication (SNI), the SNI value
// will be matched against the hosts field. For all other protocols
// the hosts will be ignored, and the port and addresses fields
// will be used if present. Note that when resolution is set to type DNS
// and no endpoints are specified, the host field will be used as the DNS name
// of the endpoint to route traffic to.
repeated string hosts = 1;

// The virtual IP addresses associated with the service. Could be CIDR
// prefix. For HTTP services, the addresses field will be ignored and
// prefix. For HTTP traffic the addresses field will be ignored and
// the destination will be identified based on the HTTP Host/Authority
// header. For non-HTTP protocols such as mongo/opaque TCP/HTTPS,
// the hosts will be ignored. If one or more IP addresses are specified,
// header. If one or more IP addresses are specified,
// the incoming traffic will be identified as belonging to this service
// if the destination IP matches the IP/CIDRs specified in the addresses
// field. If the Addresses field is empty, traffic will be identified
Expand Down