Skip to content

Conversation

idouba
Copy link
Member

@idouba idouba commented Mar 20, 2019

the traffic properties of a host can be defined using more than one VirtualService
istio/istio#12590

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 20, 2019
@istio-testing
Copy link
Collaborator

Hi @idouba. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linsun
Copy link
Member

linsun commented Mar 20, 2019

Thanks, LG to me. Defer to @frankbu @rshriram to approve this.

@frankbu
Copy link
Contributor

frankbu commented Mar 20, 2019

Thanks @idouba, but this needs to be sent to the release-1.1 branch, so we can get it into the 1.1 docs.

@ozevren ozevren requested review from andraxylia and rshriram and removed request for mandarjog and ozevren March 20, 2019 21:05
@andraxylia andraxylia changed the title update host desc that a host can be defined uing more than one vs update host desc that a host can be defined using more than one vs Mar 20, 2019
@andraxylia
Copy link
Contributor

/lgtm
/approve

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andraxylia, idouba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@idouba
Copy link
Member Author

idouba commented Mar 21, 2019

@frankbu release 1.1 pls refer to #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants