Skip to content

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Mar 20, 2019

When approving:

don't do regular lgtm/merge. an admin needs to do merge commit, which we don't see as an option

mtail and others added 30 commits February 21, 2019 10:24
* document MCP

* add additional note on NACK behavior

* add a note about ignoring stale nonces
* Add envoy metrics service configuration to ProxyConfig

Similar to the statsd sink config, this change is in preparation for adding support for the envoy metrics service API.

* Update proto.lock

* Reorder metrics_service_address just after statsd_udp_address
…stio#809)

Since "metrics service" is so ambiguous, this change specifically denotes that the config is for Envoy's metrics service API. The comments also now link to detailed info about the metrics service API.
* Generate separate pages for each networking proto

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* tweaks

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Fix interdoc references

* separate doc and go gen

* change dash to underscore

* fix

* more fixes

* makefile fix

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* remove bad target

* Revert "change dash to underscore"

This reverts commit 7fbced6.

* final update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
…#811)"

This reverts commit 5f14ead since it breaks the ability
to generate reference docs in istio.io
This reverts commit 231fadc which I accidentally pushed to the
wrong place.
* Proxy config: Add tls_certs_to_watch field

* Address PR comment
* Update gateway and sidecar hosts doc

* regen

* review comments
* Update sidecar and gateway docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* gen docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update service entry

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* updates

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
…tio#832)

* add configurable dns refresh rate to mesh for strict dns cluster, issue #12181

* add lock file
* Hosts are not ignored in ServiceEntry for HTTPs

* Clarify

* Reword

* Generate protos

* Address code review comments

* Fix typo

* generate
Signed-off-by: Kuat Yessenov <kuat@google.com>
This started out to just fix a bad link to unblock work on
istio.io, but I ended up fixing a bunch of typos/incorrect format
throughout.
* fix MeshNetworks demo

* generate

* update
Signed-off-by: Shriram Rajagopalan <rshriram@gmail.com>
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Mar 20, 2019
@howardjohn
Copy link
Member Author

/assign @kyessenov @duderino @louiscryan

@istio-testing
Copy link
Collaborator

@howardjohn: GitHub didn't allow me to assign the following users: kyessenov.

Note that only istio members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @kyessenov @duderino @louiscryan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@louiscryan
Copy link
Contributor

/lgtm
/approve

@louiscryan louiscryan added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Mar 21, 2019
@googlebot
Copy link
Collaborator

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@louiscryan
Copy link
Contributor

This is a merge PR from commits to repo that require CLA. Setting CLA to yes

@howardjohn
Copy link
Member Author

/assign @geeknoid @ozevren

@ozevren
Copy link
Contributor

ozevren commented Mar 21, 2019

/lgtm
/approve

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, louiscryan, ozevren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 87afa02 into istio:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.