Enhance Istio Ingress explanations #1023

vadimeisenbergibm · 2018-02-22T14:07:20Z

Clarify Istio Ingress vs. Kubernetes Ingress
Remove "Controller", which is a Kubernetes term, it does not add anything to understanding the concept of Istio Ingress
Minor fixes

controller is a Kubernetes term, it does not serve here any purpose

fixed cardinality

frankbu · 2018-02-23T18:34:52Z

_docs/tasks/traffic-management/ingress.md

-cluster. However, the Ingress Resource specification is very minimal,
-allowing users to specify just hosts, paths and their backing services.
-The following are the known limitations of Istio ingress:
+cluster. It allows defining a backend service per virtual host and path.


It allows one to define a backend ...

frankbu · 2018-02-23T18:35:43Z

_docs/tasks/traffic-management/ingress.md

-   `kubernetes.io/ingress.class: istio` will be ignored.
-2. Regular expressions in paths are not supported.
-3. Fault injection at the Ingress is not supported.
+Once the Istio Ingress specification is defined, the into-the-cluster traffic is directed through the `istio-ingress` pod. This allows applying Istio features, for example, monitoring and route rules, on the into-the-cluster traffic.


directed through the istio-ingress service.

frankbu · 2018-02-23T18:40:08Z

_docs/tasks/traffic-management/ingress.md

-   `kubernetes.io/ingress.class: istio` will be ignored.
-2. Regular expressions in paths are not supported.
-3. Fault injection at the Ingress is not supported.
+Once the Istio Ingress specification is defined, the into-the-cluster traffic is directed through the `istio-ingress` pod. This allows applying Istio features, for example, monitoring and route rules, on the into-the-cluster traffic.


s/. This allows applying Istio ... traffic./, so that Istio features, for example, monitoring and route rules, can be applied to the into-the-cluster traffic/

frankbu · 2018-02-23T18:40:35Z

_docs/tasks/traffic-management/ingress.md

-3. Fault injection at the Ingress is not supported.
+Once the Istio Ingress specification is defined, the into-the-cluster traffic is directed through the `istio-ingress` pod. This allows applying Istio features, for example, monitoring and route rules, on the into-the-cluster traffic.
+
+Istio Ingress specification is based on the standard [Kubernetes Ingress Resource](https://kubernetes.io/docs/concepts/services-networking/ingress/) specification, with the following differences:


The Istio Ingress specification ...

frankbu · 2018-02-23T18:42:35Z

_docs/tasks/traffic-management/ingress.md

+
+2. All other annotations are ignored.
+
+The following are the known limitations of Istio Ingress:


s/the known/known/

ldemailly · 2018-02-23T18:46:25Z

thanks @frankbu !

…mitations

vadimeisenbergibm · 2018-02-23T18:49:16Z

Thanks @frankbu ! I have applied your comments.

ZackButcher · 2018-02-26T18:18:00Z

_docs/tasks/traffic-management/ingress.md

-   `kubernetes.io/ingress.class: istio` will be ignored.
-2. Regular expressions in paths are not supported.
-3. Fault injection at the Ingress is not supported.
+Once the Istio Ingress specification is defined, the into-the-cluster traffic is directed through the `istio-ingress` service, so that Istio features, for example, monitoring and route rules, can be applied to the into-the-cluster traffic.


"can be applied to traffic entering the cluster" reads a bit better IMO.

vadimeisenbergibm · 2018-02-26T18:56:30Z

@ZackButcher thanks for your comment, I have fixed it.

vadimeisenbergibm · 2018-02-26T18:57:40Z

@geeknoid what is the procedure in this repository - should the merge be done manually for the approved PRs or it is done automatically as in istio/istio? Who should perform the merge manually?

ldemailly · 2018-02-26T19:21:15Z

_docs/tasks/traffic-management/ingress.md

 cluster. It allows one to define a backend service per virtual host and path.

-Once the Istio Ingress specification is defined, the into-the-cluster traffic is directed through the `istio-ingress` service, so that Istio features, for example, monitoring and route rules, can be applied to the into-the-cluster traffic.
+Once the Istio Ingress specification is defined, the into-the-cluster traffic is directed through the `istio-ingress` service, so that Istio features, for example, monitoring and route rules, can be applied to the traffic entering the cluster.


should you change both into-the-cluster or neither?

vadimeisenbergibm · 2018-02-26T19:39:15Z

@ldemailly Good catch. I have renamed the second appearance of "into-the-cluster" traffic and split the sentence it appears in.

geeknoid · 2018-02-27T16:39:04Z

To answer the question, this repo doesn't have a robot, so merging is done manually. If you see a green button, go ahead and merge...

…

On Mon, Feb 26, 2018 at 12:04 PM Laurent Demailly ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1023 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVucHYlfVWUXlVmBDFQTDQ6aK14cMjQOks5tYwyEgaJpZM4SPXiw> .

vadimeisenbergibm added 4 commits February 22, 2018 15:53

Istio Ingress Controller -> Istio Ingress

b54ddbf

controller is a Kubernetes term, it does not serve here any purpose

Ingress Resources -> Ingress Resource

37cce34

fixed cardinality

clarified Istio Ingress vs. Kubernetes Resource

9ccb7da

Istio ingress -> Istio Ingress

545938b

vadimeisenbergibm requested review from frankbu, louiscryan and rshriram February 22, 2018 14:07

Ingress Resource -> Ingress specification

099173a

ldemailly approved these changes Feb 23, 2018

View reviewed changes

frankbu reviewed Feb 23, 2018

View reviewed changes

vadimeisenbergibm added 2 commits February 23, 2018 20:40

it allows defining -> it allows one to define

db2152b

istio-ingress pod -> istio-ingress service

1acb007

frankbu reviewed Feb 23, 2018

View reviewed changes

vadimeisenbergibm added 2 commits February 23, 2018 20:45

rephrased the sentence about applying Istio features

b620b93

Istio Ingress -> The Istio Ingress

1f8ea41

vadimeisenbergibm added 2 commits February 23, 2018 20:47

The following are the known limitations -> The following are known li…

dda3dda

…mitations

Merge branch 'master' into explain_ingress

3d8810d

vadimeisenbergibm added 2 commits February 23, 2018 21:17

Merge branch 'master' into explain_ingress

a45c2b8

Merge branch 'master' into explain_ingress

579a7f4

ZackButcher approved these changes Feb 26, 2018

View reviewed changes

vadimeisenbergibm added 2 commits February 26, 2018 20:55

into-the-cluster traffic -> traffic entering the cluster

0b332ac

Merge branch 'master' into explain_ingress

b68e016

ldemailly reviewed Feb 26, 2018

View reviewed changes

second time: into-the-cluster traffic -> traffic entering the cluster

b9b3b55

ldemailly approved these changes Feb 26, 2018

View reviewed changes

ldemailly merged commit fdc9856 into istio:master Feb 26, 2018


		2. All other annotations are ignored.

		The following are the known limitations of Istio Ingress:

Uh oh!

Enhance Istio Ingress explanations #1023

Enhance Istio Ingress explanations #1023

Uh oh!

Conversation

vadimeisenbergibm commented Feb 22, 2018

Uh oh!

frankbu Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

frankbu Feb 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

frankbu Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

frankbu Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

frankbu Feb 23, 2018

Choose a reason for hiding this comment

Uh oh!

ldemailly commented Feb 23, 2018

Uh oh!

vadimeisenbergibm commented Feb 23, 2018

Uh oh!

ZackButcher Feb 26, 2018

Choose a reason for hiding this comment

Uh oh!

vadimeisenbergibm commented Feb 26, 2018

Uh oh!

vadimeisenbergibm commented Feb 26, 2018

Uh oh!

ldemailly Feb 26, 2018

Choose a reason for hiding this comment

Uh oh!

vadimeisenbergibm commented Feb 26, 2018

Uh oh!

geeknoid commented Feb 27, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

frankbu Feb 23, 2018 •

edited

Loading