Skip to content

Fix wrong port number for https ingress #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2018
Merged

Fix wrong port number for https ingress #1041

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
408e0c5
Fixe wrong port number
YaweiWu Feb 28, 2018
892f69b
Merge branch 'master' into patch-2
geeknoid Feb 28, 2018
9ebdf30
Merge branch 'master' into patch-2
ZackButcher Mar 8, 2018
3956588
Merge branch 'master' into patch-2
ldemailly Mar 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions _docs/tasks/traffic-management/ingress.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ The following are known limitations of Istio Ingress:
169.47.243.100
```

along with the istio-ingress service's nodePort for port 80:
along with the istio-ingress service's nodePort for port 443:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that seems odd, what caused this change ? the ingress will only listen on 443 if you have certs

Copy link
Member

@ldemailly ldemailly Mar 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm I didn't see this was in the https ingress section - thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(We chatted in slack but posting here in case others are curious.)

This is updating the HTTPS section of the doc. The ingress doc covers HTTP and HTTPS, and we'd previously directly copy/pasted the HTTP verification section into the HTTPS section; this corrects the HTTPS section to use 443 and https rather than http in the curl URL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I updated the pr title to make it more clear


```bash
kubectl -n istio-system get svc istio-ingress
Expand All @@ -250,7 +250,7 @@ The following are known limitations of Istio Ingress:
```

```bash
export INGRESS_HOST=169.47.243.100:31486
export INGRESS_HOST=169.47.243.100:32254
```

1. Access the httpbin service using _curl_:
Expand All @@ -274,7 +274,7 @@ The following are known limitations of Istio Ingress:
see a HTTP 404 error

```bash
curl -I -k http://$INGRESS_HOST/headers
curl -I -k https://$INGRESS_HOST/headers
```

```
Expand Down