Skip to content

Modify the format #11459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Modify the format #11459

wants to merge 3 commits into from

Conversation

@hueifeng
Copy link
Member

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

  • Configuration Infrastructure
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

@hueifeng hueifeng requested a review from a team as a code owner June 17, 2022 15:06
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2022
@istio-testing
Copy link
Contributor

Hi @hueifeng. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericvn ericvn added the translation/chinese Translation item label Jun 17, 2022
@ericvn
Copy link
Contributor

ericvn commented Jun 17, 2022

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 17, 2022
@hueifeng
Copy link
Member Author

/retest

@hueifeng
Copy link
Member Author

/retest-required

@istio-testing
Copy link
Contributor

@hueifeng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio.io 4b1be5c link true /test lint_istio.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kebe7jun
kebe7jun reviewed Jul 8, 2022
View reviewed changes
Copy link
Member

@kebe7jun kebe7jun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

似乎没必要修改。

@windsonsea
Copy link
Member

/close
because it's not necessary to modify

@windsonsea windsonsea closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kebe7jun kebe7jun kebe7jun left review comments

Assignees

No one assigned

Labels

kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/chinese Translation item

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hueifeng @istio-testing @ericvn @windsonsea @kebe7jun @istio-policy-bot