Fix: Helm Canary Doc Tests #16856
Closed
Fix: Helm Canary Doc Tests #16856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/XS
Member
Author
|
@dhawton This has to go in it is blocking all the PRs. |
Member
|
#16865 was a better fix and is in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
helm_test.shto disable Shellcheck warning SC2218.Fixes #16730
- ShellCheck reports
- Added
See:- LogsSC2218 (This function is only defined later. Move the definition up)for functions likeset_multi_network_vars, setup_helm_repo, configure_trust, and verify_load_balancingHowever, these functions are not defined inside this script — they are sourced from other scripts(common.sh, gateway-api.sh).At runtime, the script works as expected. ShellCheck simply cannot follow external sourcesSC2218to the existing # shellcheck disable directive at the top of the script to avoid false positives.Impact No change in functionality Only lint noise is suppressed
Reviewers