Skip to content

Fix SC2218 lint failure #16865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2025
Merged

Fix SC2218 lint failure #16865

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d6838e
WIP - Try to fix SC2218 lint failure
kfaseela Sep 10, 2025
d01ce20
fix ambient multi cluster
kfaseela Sep 10, 2025
627baa4
Move shellcheck next to the source line
kfaseela Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions content/en/docs/ambient/install/multicluster/multi-primary_multi-network/helm_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,12 @@ set -e
set -u
set -o pipefail

source content/en/docs/ambient/install/multicluster/common.sh
#shellcheck source=tests/util/gateway-api.sh
source "tests/util/gateway-api.sh"

#shellcheck source=content/en/docs/setup/install/multicluster/common.sh
source "content/en/docs/ambient/install/multicluster/common.sh"

set_multi_network_vars
setup_helm_repo

Expand Down Expand Up @@ -82,14 +85,14 @@ function enable_endpoint_discovery {
snip_enable_endpoint_discovery_2
}


time configure_trust
time install_istio_helm
time enable_endpoint_discovery
time verify_load_balancing

# @cleanup
source content/en/docs/setup/install/multicluster/common.sh
#shellcheck source=content/en/docs/setup/install/multicluster/common.sh
source "content/en/docs/setup/install/multicluster/common.sh"
set_multi_network_vars

function cleanup_cluster1_helm {
Expand Down